Redo integration test output #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Much more coherent — shows output of inner tests consistently regardless of how they fail, with a nice prefix. Removes the clunky `assert_success` function.
|
Is there a reason why this uses an obsolete os_pipe version ( |
|
Possibly MSRV. Would happily take a PR to upgrade assuming it's compatible (tests will catch it) |
|
Hm, I don't think so. os_pipe 0.9 doesn't specify MSRV in its metadata, and os_pipe 1.2.0+ specifies an MSRV of 1.63 ... but cargo-insta already has an MSRV of 1.65. I'll look into updating it with a PR. 👍🏼 |
max-sixty
pushed a commit
that referenced
this pull request
Nov 17, 2024
Updates the `os_pipe` dev-dependency from 0.9.0 to 1.2.1, the latest release. [Version 1.0.0](https://github.com/oconnor663/os_pipe.rs/releases/tag/1.0.0) stabilized the 0.9.0 API without changes. [Version 1.2.0](https://github.com/oconnor663/os_pipe.rs/releases/tag/1.2.0) bumped the MSRV to 1.63; this is fine since `os_pipe` is only used by `cargo-insta`, which has MSRV 1.65.0. Based on discussion in #633.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much more coherent — shows output of inner tests consistently regardless of how they fail, with a nice prefix. Removes the clunky
assert_successfunction.