Allow trailing commas to work for file snapshots #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was implemented for some macros but not others (possibly this was my mistake when simpliyfing the macros...). This centralizes their handling in two central macros. FYI I'm 80% confident I've handled all cases -- not sure how else they could get through, but any reports of misses are welcome...
narpfel
added a commit
to narpfel/insta
that referenced
this pull request
Apr 3, 2024
This commit basically reverts 2ade0af from PR mitsuhiko#454.
narpfel
added a commit
to narpfel/insta
that referenced
this pull request
Apr 3, 2024
This commit basically reverts 2ade0af from PR mitsuhiko#454.
narpfel
added a commit
to narpfel/insta
that referenced
this pull request
Apr 3, 2024
This commit basically reverts 2ade0af from PR mitsuhiko#454.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was implemented for some macros but not others (possibly this was my mistake when simplifying the macros...). This centralizes their handling in two central macros.
Inline macros don't work, because of how we replace the values, so we still need to fix those. But I ran out of time on this so pushed the partial fix.