Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Being more permissive to files changing under insta #380

Closed
max-sixty opened this issue Jun 9, 2023 · 0 comments · Fixed by #484
Closed

Being more permissive to files changing under insta #380

max-sixty opened this issue Jun 9, 2023 · 0 comments · Fixed by #484

Comments

@max-sixty
Copy link
Collaborator

I'm often getting an error: error: No such file or directory (os error 2) which exits the process.

I get this when reviewing snapshots, and occasionally when just running cargo insta test --accept.

When reviewing a snapshot, I think it's because a pending snapshot has been removed by another process. I had a look for where in the code it was doing the file reading, but actually couldn't find it after 10 minutes and thought posting an issue was reasonable — if you can point me in the right direction I could change this to print an warning but then continue — if there's no longer a pending snapshot then skipping its review seems very reasonable?

I'm not sure why it happens when running cargo insta test --accept. Any ideas?
@max-sixty max-sixty mentioned this issue Jun 27, 2023
Closed
max-sixty added a commit to max-sixty/insta that referenced this issue Mar 3, 2024
@max-sixty
Better missing file errors
b0b3336 
I tracked down mitsuhiko#380 at last.

This doesn't solve the problem, but does show which file is being deleted, so it's not such a mystery. A future PR could change how these are handled so it's more permissive.

For example:

```
error: File error for `/Users/maximilian/workspace/prql/prqlc/prqlc-parser/src/.lexer.rs.pending-snap': No such file or directory (os error 2)
```
@max-sixty max-sixty mentioned this issue Mar 3, 2024
Merged
max-sixty added a commit to max-sixty/insta that referenced this issue May 2, 2024
@max-sixty
Be robust to removing pending snapshots during review
281e963 
Closes mitsuhiko#380
@max-sixty max-sixty mentioned this issue May 2, 2024
Merged
mitsuhiko pushed a commit that referenced this issue May 15, 2024
@max-sixty
Be robust to removing pending snapshots during review (#484)
517d555 
Closes #380
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Be robust to removing pending snapshots during review max-sixty/insta
1 participant
@max-sixty