-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added preliminary SDK support to "rand_data" plugin #427
Conversation
Thanks @patrickjcasey! I'll take a look tomorrow! 😄 |
ac59a52
to
b81a3bd
Compare
Re: a prelude crate As far as I see, excluding the re-exports the only types users need access to is I'd be in favor of adding a Leave this and the reexport crate as a separate commit on top for now in case we need to walk it back |
As for documentation and testing, those are important, but they can be done after the SDK is merged |
d1f88b3
to
f007d93
Compare
I concur on the idea of a |
f007d93
to
47db5cf
Compare
47db5cf
to
b13c7e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Great work
This pull request is the first pass at using the
hipcheck-sdk
crate to make a plugin forhipcheck
The goal of the SDK is to make it as easy as possible for plugin authors to write new plugins for hipcheck!
The hidden
hc plugin
command no accepts another flag--sdk
that will use thedummy_rand_data_sdk
plugin, rather than thedummy_rand_data
pluginThere are some outstanding issues that still need to be addressed, whether in this issue, or in another issue in the future:
serde_json::Value
,schemars::schema::SchemaObject
, ...)hipcheck-sdk
cratehipcheck-sdk
crate to ensure it is producing the desired behaviors and integrates cleanly with whathipcheck
is expectingprelude
module so a user would be able touse hipcheck_sdk::prelude::*
and have the most common imports?