Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add plugin cache dir to child PATH (last) when spawning #706

Closed
j-lanson opened this issue Dec 9, 2024 · 0 comments · Fixed by #715
Closed

add plugin cache dir to child PATH (last) when spawning #706

j-lanson opened this issue Dec 9, 2024 · 0 comments · Fixed by #715
Assignees
Labels
product: hc Relates to the core "hc" binary type: bug Something isn't working type: chore Clean up or management task.
Milestone

Comments

@j-lanson
Copy link
Collaborator

j-lanson commented Dec 9, 2024

docker entrypoints for plugins will probably have references to artifacts in the plugin cache dir (such as a container file), but we don't execute the plugin from that directory so these files will fail to be found. Update the plugin child process's PATH at spawn time by pushing canon_working_dir.

@j-lanson j-lanson added type: bug Something isn't working type: chore Clean up or management task. product: hc Relates to the core "hc" binary labels Dec 9, 2024
@j-lanson j-lanson added this to the 3.9.0 milestone Dec 9, 2024
@j-lanson j-lanson assigned aamohd and j-lanson and unassigned aamohd Dec 9, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Hipcheck Dev Roadmap Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: hc Relates to the core "hc" binary type: bug Something isn't working type: chore Clean up or management task.
Projects
Status: Done
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants