Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin download/execution improvements #715

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

j-lanson
Copy link
Collaborator

Resolves #706 . Resolves #707 .

Some quality of life changes for plugins.

  • Add the plugin's cache path to the plugin's process PATH to help plugin process find artifacts when running
  • Add force: bool to plugin downloading function, and use existing plugin with right version in cache if exists and force=false instead of pulling and decompressing every time
  • Change plugin bundle extraction to only copy up artifacts from a subdir if it matches name of the bundle minus the compression extension. Previous impl could accidently copy unrelated files if passed extract_dir contained other subdirs already.

@j-lanson j-lanson added type: enhancement New feature or request type: chore Clean up or management task. product: hc Relates to the core "hc" binary labels Dec 12, 2024
@j-lanson j-lanson added this to the 3.9.0 milestone Dec 12, 2024
@j-lanson j-lanson self-assigned this Dec 12, 2024
@j-lanson j-lanson changed the title Jlanson/downloaded plugin improvements downloaded plugin improvements Dec 12, 2024
@j-lanson j-lanson changed the title downloaded plugin improvements plugin download/exection improvements Dec 12, 2024
@j-lanson j-lanson changed the title plugin download/exection improvements plugin download/execution improvements Dec 12, 2024
@j-lanson j-lanson force-pushed the jlanson/downloaded-plugin-improvements branch from 4c84f27 to 1356559 Compare December 13, 2024 13:50
Copy link
Contributor

@patrickjcasey patrickjcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and functions as expected on my machine!

@patrickjcasey patrickjcasey merged commit 645d356 into main Dec 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: hc Relates to the core "hc" binary type: chore Clean up or management task. type: enhancement New feature or request
Projects
Status: Done
Status: Done
2 participants