Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

Add to depend #149

Closed
wants to merge 2 commits into from
Closed

Add to depend #149

wants to merge 2 commits into from

Conversation

robthew
Copy link
Contributor

@robthew robthew commented Aug 19, 2020

No description provided.

Signed-off-by: Robert Thew <[email protected]>
Signed-off-by: Robert Thew <[email protected]>
@aaronlippold aaronlippold temporarily deployed to mitre-heimdall-pr-149 August 19, 2020 20:14 Inactive
@robthew
Copy link
Contributor Author

robthew commented Aug 19, 2020

Fixes #148

@robthew robthew requested a review from rbclark August 20, 2020 17:17
Copy link
Collaborator

@rbclark rbclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this removes a lot of fields from the database without declaring migrations for them. Were these fields removed on purpose or is this the side-effect of some other migration that was run?

@robthew
Copy link
Contributor Author

robthew commented Aug 20, 2020

Some tables from a development branch that has not been deployed got included in a previous schema.rb. This schema.rb removes them so the schema actually matches the tables in master.

@rbclark
Copy link
Collaborator

rbclark commented Aug 20, 2020

It looks like those were merged about 6 months ago. This means that anyone who has deployed in the last 6 months has those tables in their schema. In that case a migration most likely would need to be written to properly clean them out. It would be best if that wasn't done as part of this PR.

@robthew robthew closed this Aug 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants