Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed golang error with Dockerfile #2802

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

noperse
Copy link
Contributor

@noperse noperse commented Aug 4, 2023

Description

Was running into an error using the provided Dockerfile, error related to golang.
image

Type of change

Changed from installing go from source, to using apt, this resolved the issue.
image

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Running an instance with modified Dockerfile was successful

Please describe the tests that you ran to verify your changes.
docker build . --build-arg WIN_BUILD=true -t caldera:latest
docker-compose up

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

Copy link
Contributor

@clenk clenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good change. Reason for installing from source was originally that Ubuntu didn't have a recent enough version of Go in their repositories (#2524) but it does now.

@clenk clenk requested review from elegantmoose and removed request for elegantmoose September 26, 2023 14:45
@clenk
Copy link
Contributor

clenk commented Sep 27, 2023

Hmm, actually if we merge in mitre/sandcat#434 then we will have the same issue. The latest docker image is 22.04 which has Golang v1.18 but the sandcat PR will require v1.19. We need to either use the 23.04 docker image as the base, or compile a more recent version of Go from source.

@clenk clenk mentioned this pull request Oct 5, 2023
5 tasks
@elegantmoose elegantmoose merged commit 151f311 into mitre:master Oct 19, 2023
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants