Increase test coverage #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add collections tests
- Add stix20 tests
- Extract collection from the testing_data.py to a collection-1.json
keeping it available for import from the former file
- Enable GH test job
|
Kudos, SonarCloud Quality Gate passed!
|
|
Can any of the code owners review this PR? Thank you |
|
Thank you so much for your contributions! They look good to me so I'll go ahead and merge it in now. Since they still take a fair chunk of time to run I'l comment the GitHub workflow out after I see them succeed once, but this is really helpful! |
|
Thanks for merging this, Jared! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi mitreattack-python team.
Please consider this PR aiming to partially address #86:
I enabled the GH test job (can be disabled back if needed as it still takes 10+ minutes to complete) and added some unrelated minor code changes by running black formatter.
Please let me know if you'd like the PR code to be somehow improved/restructured etc.
The successful test job run.
Questions/concerns: while working on the PR I've noticed some inconsistency with the json files encoding (utf-8 vs utf-16). It looks like the added .json files being recognized by GH diff as binary. Not sure if I did that in a right way here as haven't worked w/ utf-16 jsons before.
The coverage report screenshot:
