Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible_mitogen: Fix dnf module by patching include of dnf.cli #1230

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

psvmcc
Copy link
Contributor

@psvmcc psvmcc commented Jan 28, 2025

Fix Workaround for #1143

@moreati
Copy link
Member

moreati commented Jan 28, 2025

Rerunning failed jobs due to #1058

@moreati
Copy link
Member

moreati commented Jan 28, 2025

Thanks. That's an impressively surgical (i.e. small and targeted) strike. I'm inclined to merge it.

Mitogen is a third party collection of hacks
-- Ansible maintainer, in associated Ansible bug which I'm not linking to so as not to create more noise for them

This is accurate. Mitogen does horrid things to Ansible.

With that in mind I'm pondering

  • How robust is it to Ansible changes?
  • Will anything more robust come along in the medium or long term?
  • Is there any low hanging robustness we could add?
  • Can/should the gating be tightened? E.g. by Ansible version, community.general version, ...
  • Does this warrent a regression test?

Give me a day or so. Responses/suggestions to those questions welcome, but not required.

@psvmcc
Copy link
Contributor Author

psvmcc commented Jan 28, 2025

I added comment about my debugging into #1143, maybe it can help you understand problem deeper, thanks!

@moreati moreati changed the title Fix dnf module by patching include of dnf.cli ansible_mitogen: Fix dnf module by patching include of dnf.cli Jan 30, 2025
@moreati moreati merged commit 1864048 into mitogen-hq:master Jan 30, 2025
22 checks passed
@moreati
Copy link
Member

moreati commented Jan 30, 2025

Decided I was overthinking it. Thanks, I'll get a release out in the next week or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants