Fixing sender email address and cookie name conflicts in edX deployments #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm, although it's an ambitious change set for one PR. I think we should set For reference, I think openedx/edx-platform#29001 changed the bulk mail settings, and it was backported to maple shortly before release. |
|
Desired from email addresses for MITx Online and xPRO:
|
|
one more email address:
|
This fixes two distinct and unrelated issues that we are seeing in our edX installations. - When working across installations that share a subdomain (e.g. QA and production or residential staging and live) users are unable to stay logged into the corresponding edX installations. This is due to a conflict in the cookie names related to JWT sessions for e.g. the learner MFE. This adds environment scoping to all of the cookie names that might conflict across installations. - When sending bulk emails through the instructor dashboard we are seeing various failure modes. The root of the issue is that the `BULK_EMAIL_DEFAULT_FROM_EMAIL` value needs to be overridden or else those bulk emails will be sent from `[email protected]`. This adds an appropriate value for that setting to each of the configuration templates relating to our separate deployments.
blarghmatey
force-pushed
the
edx_email_and_cookie_fixes
branch
from
77c3ab8 to
e896d63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two distinct and unrelated issues that we are seeing in our edX installations.
BULK_EMAIL_DEFAULT_FROM_EMAILvalue needs to be overridden or else those bulk emails will be sent from[email protected]. This adds an appropriate value for that setting to each of the configuration templates relating to our separate deployments.