This repository has been archived by the owner on Apr 14, 2020. It is now read-only.
Move servo setup to a config file. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch moves the controller addresses to a config file, along with the servo PWM range of motion. This allows one to use any number of servo controllers on the i2c bus, and also makes it easier to customize the servo calibration. This patch also includes a Servo Calibration GUI, which makes it much easier to calibrate both the controller and channel, as well as the min and max pwm for each servo.
|
Do you have a demo video showcasing sample usage of your changes (like the gui and maybe a sample case on using more than two servo controllers (assuming it's 16 servos per controller wow that's a lot of servos!) Just curious, did you run this on a raspberry pi zero as well? Thanks in advance. |
|
Nope to all 3. But I did find it useful just when connecting to two controllers, since different people may put them on different addresses, and put the servos on different channels.
…-Dan
On Apr 6, 2017, at 7:01 PM, Mithi Sevilla ***@***.***> wrote:
@robottwo
Do you have a demo video showcasing sample usage of your changes (like the gui and maybe a sample case on using more than two servo controllers (assuming it's 16 servos per controller wow that's a lot of servos!) Just curious, did you run this on a raspberry pi zero as well? Thanks in advance.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Thanks for your reply. I do understand how extremely useful this patch is, I'd merge this but I'd have to test it on my hardware setup first and maybe do a short readme. Thanks! |
|
I updated the readme to talk about the new functionality. |
|
@robottwo |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch moves the controller addresses to a config file, along with the servo PWM range of motion.
This allows one to use any number of servo controllers on the i2c bus, and also makes it easier to customize the servo calibration.
This patch also includes a Servo Calibration GUI, which makes it much easier to calibrate both the controller and channel, as well as the min and max pwm for each servo.