Fix severity condition

[Yurii-Zakharov]

Current condition check if violation.severity is equal or greater then inputs.severityThreshold from numbers perspective, but what we want is to check from severity perspective.

Severity perspective
1-5 where
1 - highest
5 - lowest
https://docs.pmd-code.org/pmd-doc-6.55.0/pmd_userdocs_configuring_rules.html#message-and-priority-overriding

In main branch

• We set inputs.severityThreshold = 2 which means we want to throw error when severity is 2 or greater (1).
• We run scan and violation.severity = 3 appears.
• Next conditions is checked (inputs.severityThreshold <= violation.severity) -> True
• Error is thrown. But it is not what we wanted. 2 is less then 3 from numbers meaning, but from severity perspective it is greater.

In fixSeverityCondition branch

• We set inputs.severityThreshold = 2 which means we want to throw error when severity is 2 or greater (1).
• We run scan and violation.severity = 3 appears.
• Next conditions is checked (inputs.severityThreshold >= violation.severity) -> False
• Continue without error. It is what we wanted. 2 is greater then 3 from from severity perspective.

The same way sfdx scanner plugin is working. While stating:

-s, --severity-threshold=_severity-threshold_
Throws an error when violations are found with equal or greater severity than the provided value. 

They consider this severity perspective.

https://forcedotcom.github.io/sfdx-scanner/en/v3.x/scanner-commands/run/

[mitchspano]

Good catch - thank you for your contributions