This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
support "user_data" and "config_drive" configuration options #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,7 +12,7 @@ Gem::Specification.new do |gem| | |||
| gem.summary = "Enables Vagrant to manage machines in RackSpace Cloud." | |||
| gem.homepage = "http://www.vagrantup.com" | |||
|
|
|||
| gem.add_runtime_dependency "fog", "~> 1.18" | |||
| gem.add_runtime_dependency "fog", "~> 1.22.1" | |||
There was a problem hiding this comment.
Can I get you to change the fog dependency version to 1.22 like so
gem.add_runtime_dependency "fog", "~> 1.22"That way ruby gems will pick up patch releases.
BTW, you did a great job on this PR. Once you make this one minor change, I will will merge it in.
picked up automatically
|
@krames okay, I modified the version number as requested. Thanks for the tip! |
|
Thanks! |
krames
pushed a commit
that referenced
this pull request
Jun 17, 2014
support "user_data" and "config_drive" configuration options
krames
pushed a commit
to rackspace/vagrant-rackspace
that referenced
this pull request
Jun 19, 2014
|
@michaelsbradleyjr I just released vagrant-rackspace 0.1.8 and unfortunately I had to pull this PR because vagrant-aws does not currently support fog 1.22. I have submitted PR mitchellh/vagrant-aws#253 to get this increased. I have put your changes back into the master branch and hopefully it will make it out in the next vagrant-rackspace release. /cc @elight @smashwilson |
krames
pushed a commit
that referenced
this pull request
Jun 20, 2014
…ata"" This reverts commit 6ad6a81. Conflicts: lib/vagrant-rackspace/action/create_server.rb
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fog supports the
config_driveoption as of1.16.0and theuser_dataoption as of1.22.0. Both options need to be set, for example, if one desires to deploy a CoreOS image on the Rackspace Cloud.My "test" consisted of applying these same changes to the vagrant-rackspace plugin in
~/.vagrant.d/gems/gems/(along with the changes in #99), and then successfully bringing online a CoreOS image withuser_dataadapted from the CoreOS website docs for Rackspace.I also ran
bundle exec rakeand all the tests passed, which is a good sign I suppose (the fog version bump didn't break anything), though I did not write any specs for my changes per se (I don't really know ruby).