This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Fix data race in decodeStruct #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using *reflect.StructField as map key results in a data race. I honestly do not understand why yet and can only reproduce this in the consul codebase with high concurrency but this patch fixes it. The same problem also exists in hashicorp/hcl.
magiconair
added a commit
to hashicorp/consul
that referenced
this pull request
Sep 26, 2017
10 tasks
|
@magiconair Did you ever get to the bottom of how this data race can occur? We've experienced this in production and I can't work out (barring bugs in the Go runtime) how this could cause a race. I've updated this dependency within our codebase but it is somewhat unsatisfying to not know why. |
|
@danielchatfield no idea unfortunately. |
|
@magiconair do you have any repro code? |
|
I think what I did was to run |
|
Ok thanks! |
|
@magiconair were you able to reliably reproduce? We are not able to. In production at one time we had the race repeatedly, but now we can't reproduce there either. We can't figure out what might be changing from one day to the next. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
*reflect.StructFieldas map key results in a data race. I honestlydo not understand why yet and can only reproduce this in the consul
codebase with high concurrency but this patch fixes it.
The same problem also exists in hashicorp/hcl.
hashicorp/hcl#213