Skip to content

Commit

Permalink
[SCSI] qla2xxx: Change in setting UNLOADING flag and FC vports logout…
Browse files Browse the repository at this point in the history
… sequence while unloading qla2xxx driver.

Signed-off-by: Giridhar Malavali <[email protected]>
Signed-off-by: Saurav Kashyap <[email protected]>
Cc: <[email protected]> #3.7
Signed-off-by: James Bottomley <[email protected]>
  • Loading branch information
Giridhar Malavali authored and James Bottomley committed Nov 30, 2012
1 parent a394aac commit 220d36b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions drivers/scsi/qla2xxx/qla_attr.c
Original file line number Diff line number Diff line change
Expand Up @@ -1615,8 +1615,7 @@ qla2x00_terminate_rport_io(struct fc_rport *rport)
* At this point all fcport's software-states are cleared. Perform any
* final cleanup of firmware resources (PCBs and XCBs).
*/
if (fcport->loop_id != FC_NO_LOOP_ID &&
!test_bit(UNLOADING, &fcport->vha->dpc_flags)) {
if (fcport->loop_id != FC_NO_LOOP_ID) {
if (IS_FWI2_CAPABLE(fcport->vha->hw))
fcport->vha->hw->isp_ops->fabric_logout(fcport->vha,
fcport->loop_id, fcport->d_id.b.domain,
Expand Down
3 changes: 1 addition & 2 deletions drivers/scsi/qla2xxx/qla_os.c
Original file line number Diff line number Diff line change
Expand Up @@ -2755,6 +2755,7 @@ qla2x00_remove_one(struct pci_dev *pdev)

ha->flags.host_shutting_down = 1;

set_bit(UNLOADING, &base_vha->dpc_flags);
mutex_lock(&ha->vport_lock);
while (ha->cur_vport_count) {
struct Scsi_Host *scsi_host;
Expand Down Expand Up @@ -2784,8 +2785,6 @@ qla2x00_remove_one(struct pci_dev *pdev)
"Error while clearing DRV-Presence.\n");
}

set_bit(UNLOADING, &base_vha->dpc_flags);

qla2x00_abort_all_cmds(base_vha, DID_NO_CONNECT << 16);

qla2x00_dfs_remove(base_vha);
Expand Down

0 comments on commit 220d36b

Please sign in to comment.