Fix/conversation loggin fix #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludomori99
requested changes
Oct 18, 2023
There was a problem hiding this comment.
Looks great; one note that could improve is to store more than just the timestamp of the last interaction. Would be ideal, as we discussed in the office, to have in metadata a timestamp for when the discussion was created, and all timestamps for whenever the chain is evoked, meaning whenever a question is fed to the chatbot.
|
Fixed the issues requested. Here is an example: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two small fixes I missed in the logging implementation the first time around:
metasection in each discussion for logging. This includes atime_last_usedwhich is when the discussion was last used .Tested to see if it was working in action #141