Updates to launch
#272
Merged
Updates to launch
#272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsokl
reviewed
May 6, 2022
src/hydra_zen/_launch.py
Outdated
Comment on lines
215
to
220
| if len(fields(config)) == 0: | ||
| raise ValueError( | ||
| """There is an issue with your dataclass. If you previously executed with a | ||
| `hydra/launcher` that utilizes cloudpickle (e.g., hydra-submitit-launcher), there is a known | ||
| issue with dataclasses (see: https://github.com/cloudpipe/cloudpickle/issues/386). You will have | ||
| to restart your interactive environment. To avoid this issue you can use the option `to_dictconfig=True`.""" |
There was a problem hiding this comment.
This check will prevent empty configs from working:
from hydra_zen import make_config
from dataclasses import fields
>>> fields(make_config())
()This would break some of our basic mushin workflow examples
There was a problem hiding this comment.
Actually, when you get rid of this check, it would be good to add a regression test to ensure that launch always supports an empty config.
There was a problem hiding this comment.
You could check the length of the fields before and after the run, and then raise a warning to the user.
There was a problem hiding this comment.
yeah, I was just thinking about that.
jgbos
commented
May 6, 2022
| + "`to_dictconfig=True`." | ||
| ) | ||
| ): | ||
| with pytest.warns(UserWarning): |
There was a problem hiding this comment.
ahh, that's how you do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
dataclassinput to aDictConfig. This is a fix and response to the cloudpickle issuelaunchto comform with Hydra's Compose API. Currently we cannot usecomposeas it does not supportmuliturn, but these changes make it easy to update ifcomposeeventually supportsmultirun.@rsokl I added cloudpickle to some of the test requirements. I'm not sure how to test without it.