Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Spell Points are deducted even if Activity is set to Not consume Spell Slots #118

Open
BlackOtter123 opened this issue Dec 19, 2024 · 7 comments
Assignees
Labels
Enhancement New feature or request Feature request Fixed / Waiting confirmation Probably fixed issue. More Information Needed Further information is requested Work in Progress Something to work on

Comments

@BlackOtter123
Copy link

In D&D5e 4.1.2, spells can use different Activities for individual parts of the spell. Activities can be set to not consume any Spell Slots.
However, while "Consume Spell Slot" toggle is off, the spell points are still consumed normally. It is also impossible to manually toggle the spell point consumption off, because the prompt is disabled when that setting is off.

@misthero
Copy link
Owner

ok, but you can set it to recover spell points (the same amount that would be spent) using a negative value on item uses.

immagine

this is not really a bug but a missing feature, right now the activity is not implemented with the spell points module since if you want to use spell points with activities you can just create a custom item and use it as spell points without this module.

what is your use case? why you want a spell that doesn't consume slots nor spell points? can't you make it a cantrip?

@misthero misthero added the More Information Needed Further information is requested label Dec 21, 2024
@BlackOtter123
Copy link
Author

BlackOtter123 commented Dec 22, 2024

That's a useful solution, but won't work with upscaling without additional tinkering I think.
In my usecase, I use spells such as Eyebite which use Concentration, but then allow for extra free activities while the spell is active (i.e. target a different creature, make ranged attacks with Crown of Stars etc). Those activities do not count as separate castings of that spell so they wouldn't consume spell slots/spell points. And it's useful to keep all the spell's effects as sub-activities that way. Sometimes they also have different effects than the main casting so using a Forward activity isn't a clean solution (it doubles the number of entries)

@misthero misthero added Enhancement New feature or request Feature request labels Dec 31, 2024
@TomChristoffer
Copy link

+1 I have also found use cases where this would be helpful.

@Torgaard
Copy link

Recently switched to DnDv4.2 and ya, can confirm. This one's kind of a bummer. Everything else works wonderfully with Spell Points, but in my 'magic heavy' version of the Forgotten Realms with lots o' fun magic items with little powers, this'll be a little tricky. A little 'More Information' to follow protocol with the tag on this issue: If I have an item where I add the 'Cast' Activity, in every scenario I've tried - even the one you suggested (using a negative value to refund a point) - I can't get it to work. If I setup the Activity in the magic item in the character's inventory to do the negative value, it just flatout doesn't seem to work. Tried a few variations, made sure players had change permissions for altering Spell Point value, etc.

I can't set it up in the spell itself (in the 'Save' Activity for example), because the spell itself would either be sitting in a Compendium or plopped into a folder in my Items section (in the World itself) - but of course if that's where it's sitting, you can't actually assign it to use 'Item Uses' at all, because it's not actually sitting IN a character sheet (ie it has no 'Items' to reference, cuz it's not sitting in a sheet with any Items). I even tried using the UUID of the 'Spell Points' Feature on the character sheet and pasted it into the 'Target' field for the spell sitting in my World (and not on the character sheet), but that didn't work.

While it's true, I could just basically not use the Spell Points module and just setup my own Spell Points item on the sheet and then use 'Item Uses' from that create item, ack - that would be shame. Your module is awesome! Love, love, love the little Spell Points progress bar, plus it would be a semi-big pain to manually have to setup every spell for everybody to deduct 'X' points (which yours so beautifully does auto-magically).

And thank you for the module and all the hard work you've put into it - you transformed our game, we've been using it since the first week you released it, and my players flipped.

@misthero
Copy link
Owner

If I have an item where I add the 'Cast' Activity, in every scenario I've tried - even the one you suggested (using a negative value to refund a point) - I can't get it to work. If I setup the Activity in the magic item in the character's inventory to do the negative value, it just flatout doesn't seem to work. Tried a few variations, made sure players had change permissions for altering Spell Point value, etc.

Hello, thankyou, and that's probably a bug, the item should consume/add to the spellpoints item if the activity is correctly configured. Probably there is a javascript error somewhere. I'll investigate this.

About disabling the spellpoints use from a spell with an activity that shoudn't use spellpoints (the original topic of this issue), I'm currently trying to understand how to implement that without breaking other functionalities.

@misthero misthero added the Work in Progress Something to work on label Jan 25, 2025
@misthero misthero self-assigned this Feb 1, 2025
@misthero
Copy link
Owner

misthero commented Feb 1, 2025

this should be fixed in latest release, if you disable Consume Spell Slot also spellpoints won't be spent. a notice should appear in the activity consumption tab to remember that

Image

@misthero misthero added the Fixed / Waiting confirmation Probably fixed issue. label Feb 1, 2025
@Torgaard
Copy link

Torgaard commented Feb 2, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Feature request Fixed / Waiting confirmation Probably fixed issue. More Information Needed Further information is requested Work in Progress Something to work on
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

4 participants