Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protocol-reference.md with V24 bucket info #65

Merged
merged 3 commits into from
Jan 3, 2023
Merged

Update protocol-reference.md with V24 bucket info #65

merged 3 commits into from
Jan 3, 2023

Conversation

qwahzi
Copy link
Collaborator

@qwahzi qwahzi commented Dec 29, 2022

Updating from 129 to 62 buckets, per:
nanocurrency/nano-node#3980

Updating from current block balance to max of current or previous, per: nanocurrency/nano-node#4022

Updating from 129 to 62 buckets, per:
nanocurrency/nano-node#3980

Updating from current block balance to max of current or previous, per:
nanocurrency/nano-node#4022
@mistakia mistakia added the need/triage Needs initial labeling and prioritization label Dec 29, 2022
Update protocol-reference.md Election Scheduler section with election_scheduler::activate notable function & adjust wording for pre vs post V24 clarity
Update protocol reference link to a more static tagged release instead of the develop branch (which can change)
@mistakia mistakia merged commit 195fdaa into mistakia:main Jan 3, 2023
@qwahzi qwahzi deleted the patch-1 branch January 3, 2023 23:44
@My1
Copy link

My1 commented Jan 6, 2023

I'd rather say "new balance" instead of current for the comparative sentence, as it did iirc work based on the new block's balance and "current" would in theory when talking about the queue of transactions refer to the confirmed frontier, wouldnt it?

@mistakia
Copy link
Owner

mistakia commented Jan 6, 2023

I'd rather say "new balance" instead of current for the comparative sentence, as it did iirc work based on the new block's balance and "current" would in theory when talking about the queue of transactions refer to the confirmed frontier, wouldnt it?

What about frontier block balance? Less ambiguous but maybe a little wordy/technical.

@My1
Copy link

My1 commented Jan 6, 2023

well frontier can still meant the block that's the currently confirmed frontier, or the block in the bucket, which is also referred to as a frontier e.g. in the RPC.

instead of new "incoming" might also be a term that could be used

@mistakia
Copy link
Owner

What about checked frontier block balance? and perhaps make checked a link to a glossary entry for checked block

@My1
Copy link

My1 commented Jan 12, 2023

Tbh i don't even know which balance has actually been used in v22/23 but i would have expected the balance prior to the block you are trying to confirm, so the confirmed frontier. Otherwise you could just have moved your buckets around by a send/recieve including your unconfirmed things.

ATXMJ pushed a commit to ATXMJ/nano-community that referenced this pull request Sep 16, 2024
* Update protocol-reference.md with V24 bucket info

Updating from 129 to 62 buckets, per:
nanocurrency/nano-node#3980

Updating from current block balance to max of current or previous, per:
nanocurrency/nano-node#4022

* Update protocol-reference prioritization notable functions

Update protocol-reference.md Election Scheduler section with election_scheduler::activate notable function & adjust wording for pre vs post V24 clarity

* Update protocol reference link to tagged vs develop

Update protocol reference link to a more static tagged release instead of the develop branch (which can change)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants