pref: Optimize client imports #9506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
うーん、osの関数を全部constで定義すればエラー吐かなくなるか？ (もう寝るけど) |
Codecov Report
@@ Coverage Diff @@
## develop #9506 +/- ##
========================================
Coverage 22.62% 22.62%
========================================
Files 731 731
Lines 68477 68477
Branches 2028 2028
========================================
Hits 15493 15493
Misses 52984 52984 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@/scripts/api の読み込みを一番上にしたら直ったわ |
|
p1.a9z.devに適用中 |
|
関数定義constにしないとダメ？ |
|
@tamaina |
api先頭にしたのでfunctionに戻していいいかも |
|
2日手をつけてなくて辛い |
This reverts commit 34f2feb.
|
done |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
import 'vite/modulepreload-polyfill';を追加した結果popupにComponentを渡せるようになったため、メニューなどのコンポーネントをdynamic importではなく通常のimportにするようにWhy
メニューやポップアップの表示の遅延を減らしたい
Additional info (optional)
p1.a9z.devに適用しようとしたらosのapi関数の定義のところでコケた多分直った直ってなかった