Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): ロックダウンされた期間指定のノートがStreaming経由でLTLに出現するのを修正 #15200

Merged

Conversation

tai-cha
Copy link
Contributor

@tai-cha tai-cha commented Jan 2, 2025

What

下記現象の修正

  • LTLにストリーム経由でロックダウンされたノートがノートの内容が表示されたまま流れることがある(未来の日時を設定している等)

Why

ロックダウンしたノートが表示され続けるのは本意ではないと考えられるため

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Jan 2, 2025
@tai-cha

This comment was marked as outdated.

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 40.32%. Comparing base (3c81926) to head (d9df46d).
Report is 18 commits behind head on develop.

Files with missing lines Patch % Lines
...ges/backend/src/core/entities/NoteEntityService.ts 28.57% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #15200      +/-   ##
===========================================
+ Coverage    39.96%   40.32%   +0.35%     
===========================================
  Files         1563     1564       +1     
  Lines       197878   198082     +204     
  Branches      3646     3840     +194     
===========================================
+ Hits         79080    79870     +790     
+ Misses      118193   117609     -584     
+ Partials       605      603       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 2, 2025

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

@tai-cha
Copy link
Contributor Author

tai-cha commented Jan 2, 2025

いや、本質的にノートのユーザー情報とフォロー関係を見てTLのノート取得部分を変更する必要があるな
LTLに非公開なノートが配信されてしまう問題の修正に関しては一回戻して別PRに変更しよう

@tai-cha tai-cha force-pushed the fix/lockdown-with-stream branch from d3d0ccf to f96eae0 Compare January 2, 2025 02:21
@tai-cha tai-cha marked this pull request as ready for review January 2, 2025 02:23
@tai-cha tai-cha changed the title fix(backend): 期間指定のノートが一定条件でLTLに出現するのを修正 fix(backend): 期間指定のノートがStreaming経由でLTLに出現するのを修正 Jan 2, 2025
@tai-cha tai-cha changed the title fix(backend): 期間指定のノートがStreaming経由でLTLに出現するのを修正 fix(backend): ロックダウンされた期間指定のノートがStreaming経由でLTLに出現するのを修正 Jan 2, 2025
@tai-cha
Copy link
Contributor Author

tai-cha commented Jan 2, 2025

For Reviewers: Streamに乗せるときにskipHideが適用されるがこの場合visibilityの変更がされていなかったということです

const noteObj = await this.noteEntityService.pack(note, null, { skipHide: true, withReactionAndUserPairCache: true });
this.globalEventService.publishNotesStream(noteObj);

@mi-gh-maintainer mi-gh-maintainer bot merged commit d783531 into misskey-dev:develop Jan 8, 2025
33 checks passed
Copy link

Thank you 🙏

@tai-cha
Copy link
Contributor Author

tai-cha commented Jan 8, 2025

あ、CHANGELOG忘れてるじゃん

@github-actions github-actions bot mentioned this pull request Jan 8, 2025
Ruruke pushed a commit to Ruruke/rukey that referenced this pull request Jan 10, 2025
…#15200)

* fix(backend): skipHideなときにもロックダウンされたノートのprivate化をするように

* fix linting

* Update packages/backend/src/core/entities/NoteEntityService.ts

* Fix: type error

* Remove unneeded await

* Fix: typo

* Remove skipTreatVisibillity
@github-actions github-actions bot mentioned this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

2 participants