-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(backend): ロックダウンされた期間指定のノートがStreaming経由でLTLに出現するのを修正 #15200
fix(backend): ロックダウンされた期間指定のノートがStreaming経由でLTLに出現するのを修正 #15200
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #15200 +/- ##
===========================================
+ Coverage 39.96% 40.32% +0.35%
===========================================
Files 1563 1564 +1
Lines 197878 198082 +204
Branches 3646 3840 +194
===========================================
+ Hits 79080 79870 +790
+ Misses 118193 117609 -584
+ Partials 605 603 -2 ☔ View full report in Codecov by Sentry. |
このPRによるapi.jsonの差分 |
いや、本質的にノートのユーザー情報とフォロー関係を見てTLのノート取得部分を変更する必要があるな |
d3d0ccf
to
f96eae0
Compare
For Reviewers: Streamに乗せるときにskipHideが適用されるがこの場合visibilityの変更がされていなかったということです misskey/packages/backend/src/core/NoteCreateService.ts Lines 611 to 613 in df789ce
|
Thank you 🙏 |
あ、CHANGELOG忘れてるじゃん |
…#15200) * fix(backend): skipHideなときにもロックダウンされたノートのprivate化をするように * fix linting * Update packages/backend/src/core/entities/NoteEntityService.ts * Fix: type error * Remove unneeded await * Fix: typo * Remove skipTreatVisibillity
What
下記現象の修正
Why
ロックダウンしたノートが表示され続けるのは本意ではないと考えられるため
Additional info (optional)
Checklist