Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): serverContextの型エラーを修正 #15131

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Dec 14, 2024

What

  • frontend側のserverContextで返るuser型はfrontend-embedとは違いUserDetailedなので修正
  • getServerContextを使うと出る謎の型エラーを修正(内部的にassertServerContextを使うとかでも駄目だったので本当に謎。frontend-embedと実装方法を合わせる(現場でassertする)とエラーは出なくなった)

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Dec 14, 2024
Copy link

codecov bot commented Dec 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 19.20%. Comparing base (dac3b1f) to head (9a4c60c).
Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/server-context.ts 0.00% 5 Missing ⚠️
packages/frontend/src/pages/note.vue 0.00% 4 Missing ⚠️
packages/frontend/src/pages/clip.vue 0.00% 3 Missing ⚠️
packages/frontend/src/pages/user/index.vue 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15131       +/-   ##
============================================
- Coverage    38.91%   19.20%   -19.72%     
============================================
  Files         1563      728      -835     
  Lines       197745   103810    -93935     
  Branches      3330      992     -2338     
============================================
- Hits         76960    19940    -57020     
+ Misses      120174    83315    -36859     
+ Partials       611      555       -56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit 0804092 into misskey-dev:develop Dec 16, 2024
22 checks passed
@syuilo
Copy link
Member

syuilo commented Dec 16, 2024

🙏

@kakkokari-gtyih kakkokari-gtyih deleted the fix-server-context-type branch December 16, 2024 00:14
Ruruke pushed a commit to Ruruke/rukey that referenced this pull request Dec 16, 2024
* fix(frontend): serverContextの型エラーを修正

* add comment
Ruruke added a commit to Ruruke/rukey that referenced this pull request Dec 17, 2024
Ruruke added a commit to Ruruke/rukey that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

2 participants