Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): embedの動作に必要な値を復活させる #14633

Merged

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Sep 25, 2024

What

Why

frontend-shared/js/config.ts にはHTML要素を参照する実装があるが、embed htmlで一部要素が提供されておらず、表示がおかしくなることがあるため

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Sep 25, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.58%. Comparing base (5c94b4c) to head (6a3f85e).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14633      +/-   ##
===========================================
- Coverage    39.61%   39.58%   -0.04%     
===========================================
  Files         1542     1542              
  Lines       192808   192800       -8     
  Branches      3538     2524    -1014     
===========================================
- Hits         76381    76319      -62     
- Misses      115831   115916      +85     
+ Partials       596      565      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

@syuilo syuilo merged commit aee9848 into misskey-dev:develop Sep 25, 2024
31 checks passed
@syuilo
Copy link
Member

syuilo commented Sep 25, 2024

🙏🏻

@kakkokari-gtyih kakkokari-gtyih deleted the fix-embed-missing-bits-5 branch September 25, 2024 10:47
HotoRas pushed a commit to HotoRas/misskey-neko that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants