Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misskey-js): correct noteUpdated event type #14632

Merged

Conversation

zyoshoka
Copy link
Contributor

What

misskey-js の型定義において noteUpdated イベントの型が不正確なのを修正します。

Why

肝心のノートの id も送られるはずなので

private async onNoteStreamMessage(data: GlobalEvents['note']['payload']) {
this.sendMessageToWs('noteUpdated', {
id: data.body.id,
type: data.type,
body: data.body.body,
});
}

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.32%. Comparing base (0f8b15f) to head (6c78ee4).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14632      +/-   ##
===========================================
+ Coverage    39.58%   40.32%   +0.73%     
===========================================
  Files         1542     1546       +4     
  Lines       192800   198537    +5737     
  Branches      2475     3289     +814     
===========================================
+ Hits         76319    80058    +3739     
- Misses      115916   117877    +1961     
- Partials       565      602      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit f2385a8 into misskey-dev:develop Sep 25, 2024
25 of 26 checks passed
@syuilo
Copy link
Member

syuilo commented Sep 25, 2024

🙏🏿

@zyoshoka zyoshoka deleted the incorrect-note-updated-event-type branch September 25, 2024 08:55
HotoRas pushed a commit to HotoRas/misskey-neko that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants