Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(misskey-games): Misskey Games系パッケージのlint修正+Lint CI整備 #14612

Merged
merged 12 commits into from
Sep 23, 2024

Conversation

kakkokari-gtyih
Copy link
Contributor

What

Cherry-picked from https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/623

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@kakkokari-gtyih kakkokari-gtyih marked this pull request as draft September 22, 2024 14:48
@kakkokari-gtyih
Copy link
Contributor Author

kakkokari-gtyih commented Sep 23, 2024

モノ自体はできてるけどwarnがいっぱい出てるのでそれを潰したいところではある
(やりたい方募集中) done

@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review September 23, 2024 11:15
@syuilo syuilo merged commit 7f7445a into misskey-dev:develop Sep 23, 2024
19 of 20 checks passed
@syuilo
Copy link
Member

syuilo commented Sep 23, 2024

🙏🏿

@kakkokari-gtyih kakkokari-gtyih deleted the fix-lint-2 branch September 23, 2024 15:14
HotoRas pushed a commit to HotoRas/misskey-neko that referenced this pull request Sep 27, 2024
…y-dev#14612)

* chore(lint): Fix linting in misskey-reversi

(cherry picked from commit 894934a1a7743472b2d051e2690007ae373efd76)

* chore(lint): Fix linting in misskey-bubble-game

(cherry picked from commit 1ba9c37a8d5e4ae6a98494026b87f6f6439790c7)

* enhance(gh): add lint ci for misskey games packages

* enhance(gh): fix lint ci

* fix

* revert some changes that nothing to do with lint rules

* fix

* lint fixes

* refactor: strict type def

* lint fixes

* 🎨

* 🎨

---------

Co-authored-by: 4censord <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants