Add Sign in with passkey Button #14577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
packages/frontend
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #14577 +/- ##
===========================================
+ Coverage 39.58% 41.26% +1.68%
===========================================
Files 1542 1547 +5
Lines 192801 198879 +6078
Branches 2522 2507 -15
===========================================
+ Hits 76312 82067 +5755
- Misses 115924 116247 +323
Partials 565 565 ☔ View full report in Codecov by Sentry. |
|
このPRによるapi.jsonの差分 |
yunochi
force-pushed
the
sign-in-with-passkey
branch
from
2451597 to
5209a5c
Compare
Use specific rate limiting key: 'signin-with-passkey' for passkey sign-in API to avoid collisions with signin rate-limit.
- Increased the rate limit for Passkey sign-in attempts to accommodate the two API calls needed per sign-in. - Improved error messages and handling in both the `WebAuthnService` and the `SigninWithPasskeyApiService`, providing more context and better usability. - Updated error messages to provide more specific and helpful details to the user. These changes aim to enhance the Passkey sign-in experience by providing more robust error handling, improving security by limiting API calls, and delivering a more user-friendly interface.
- Separate the flow of 1FA and 2FA. - Remove duplicate passkey buttons
yunochi
force-pushed
the
sign-in-with-passkey
branch
from
5209a5c to
61d077a
Compare
|
マージするか |
syuilo
reviewed
Sep 25, 2024
|
可能なら何らかのテストが欲しいところではあるわね |
Co-authored-by: syuilo <[email protected]>
- update index.d.ts - update ko-KR.yml, en-US.yml - Fix: Reflect Changed i18n key on MkSignin
|
サジェストのlocales/ja-JP.ymlは反映しました！またフロントも反映したバージョンでコミットしました。 |
|
👍🏻 👍🏻 |
1 task
5 tasks
HotoRas
pushed a commit
to HotoRas/misskey-neko
that referenced
this pull request
Sep 27, 2024
* Sign in with passkey (PoC) * 💄 Added "Login with Passkey" Button * refactor: Improve error response when WebAuthn challenge fails * signinResponse should be placed under the SigninWithPasskeyResponse object. * Frontend fix * Fix: Rate limiting key for passkey signin Use specific rate limiting key: 'signin-with-passkey' for passkey sign-in API to avoid collisions with signin rate-limit. * Refactor: enhance Passkey sign-in flow and error handling - Increased the rate limit for Passkey sign-in attempts to accommodate the two API calls needed per sign-in. - Improved error messages and handling in both the `WebAuthnService` and the `SigninWithPasskeyApiService`, providing more context and better usability. - Updated error messages to provide more specific and helpful details to the user. These changes aim to enhance the Passkey sign-in experience by providing more robust error handling, improving security by limiting API calls, and delivering a more user-friendly interface. * Refactor: Streamline 2FA flow and remove redundant Passkey button. - Separate the flow of 1FA and 2FA. - Remove duplicate passkey buttons * Fix: Add error messages to MkSignin * chore: Hide passkey button if the entered user does not use passkey login * Update CHANGELOG.md * Refactor: Rename functions and Add comments * Update locales/ja-JP.yml Co-authored-by: syuilo <[email protected]> * Fix: Update translation - update index.d.ts - update ko-KR.yml, en-US.yml - Fix: Reflect Changed i18n key on MkSignin --------- Co-authored-by: Squarecat-meow <[email protected]> Co-authored-by: syuilo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
#14574
Why
Password-less loginaccounts have the inconvenience of having to first enter an ID and then click the login button to authenticate the passkey.In addition, multi-account users have the inconvenience of having to enter an ID and then select a passkey from the list.
Since Misskey already uses residentKey, it is possible to skip the ID entry process and log in directly by selecting a passkey.
パスワードレスログインアカウントは、id を最初に入力してからログインボタンを押してパスキー認証をする不便があります。 さらに、複数のアカウントを持つユーザーは、id入力後にパスキーリストから選択する必要があるという不便さもあります。MisskeyはすでにresidentKeyを使用しているため、idを入力するプロセスをスキップしてパスキーを選択してすぐにログインすることが可能です。
Additional info (optional)
Checklist