-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(frontend): 設定変更時のリロード確認ダイアログが複数個表示されることがある問題を修正 #14543
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #14543 +/- ##
========================================
Coverage 19.53% 19.53%
========================================
Files 713 714 +1
Lines 100375 100375
Branches 997 998 +1
========================================
Hits 19612 19612
+ Misses 80219 80218 -1
- Partials 544 545 +1 ☔ View full report in Codecov by Sentry. |
ありがとうございます! |
ファイル名と関数名はリロードを尋ねるという情報しかないけど実際は設定の反映のために尋ねる処理になっているから名前と内容を一致させた方が良いわね |
askReloadForApplyingSettings とか? |
それかaskReloadのままにしてreasonを受け取るようにするアプローチもある |
後々使いまわせそうだからそうするか |
done |
コンフリクト解消 |
🙏🏿 |
What
Why
Fix #14541
Additional info (optional)
Checklist