Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): 設定変更時のリロード確認ダイアログが複数個表示されることがある問題を修正 #14543

Merged
merged 8 commits into from
Sep 17, 2024

Conversation

kakkokari-gtyih
Copy link
Contributor

What

  • reloadAsk実行開始時にフラグを指定し、操作完了時に解除するように
  • reloadAskを共通化

Why

Fix #14541

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Sep 12, 2024
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 50 lines in your changes missing coverage. Please review.

Project coverage is 19.53%. Comparing base (daf9ae5) to head (5f11ff8).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/scripts/reload-ask.ts 0.00% 39 Missing and 1 partial ⚠️
packages/frontend/src/pages/settings/navbar.vue 0.00% 3 Missing ⚠️
packages/frontend/src/pages/settings/theme.vue 0.00% 3 Missing ⚠️
packages/frontend/src/pages/settings/general.vue 0.00% 2 Missing ⚠️
packages/frontend/src/pages/settings/other.vue 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #14543   +/-   ##
========================================
  Coverage    19.53%   19.53%           
========================================
  Files          713      714    +1     
  Lines       100375   100375           
  Branches       997      998    +1     
========================================
  Hits         19612    19612           
+ Misses       80219    80218    -1     
- Partials       544      545    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MattyaDaihuku
Copy link

ありがとうございます!

@kakkokari-gtyih kakkokari-gtyih added this to the v2024.9.0 milestone Sep 13, 2024
@syuilo
Copy link
Member

syuilo commented Sep 15, 2024

ファイル名と関数名はリロードを尋ねるという情報しかないけど実際は設定の反映のために尋ねる処理になっているから名前と内容を一致させた方が良いわね

@kakkokari-gtyih
Copy link
Contributor Author

askReloadForApplyingSettings とか?

@syuilo
Copy link
Member

syuilo commented Sep 15, 2024

それかaskReloadのままにしてreasonを受け取るようにするアプローチもある

@kakkokari-gtyih
Copy link
Contributor Author

kakkokari-gtyih commented Sep 15, 2024

それかaskReloadのままにしてreasonを受け取るようにするアプローチもある

後々使いまわせそうだからそうするか

@kakkokari-gtyih
Copy link
Contributor Author

done

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@syuilo syuilo merged commit 3bf63dd into misskey-dev:develop Sep 17, 2024
21 of 22 checks passed
@syuilo
Copy link
Member

syuilo commented Sep 17, 2024

🙏🏿

@kakkokari-gtyih kakkokari-gtyih deleted the fix-14541 branch September 18, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

リロードしますか?のモーダルが多重に表示される問題
3 participants