Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(frontend): frontend-embed/src/to-be-sharedを共通化 #14536

Merged
merged 9 commits into from
Sep 10, 2024

Conversation

kakkokari-gtyih
Copy link
Contributor

What

書いてあるとおり

Why

Fix #14530

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 36.45833% with 61 lines in your changes missing coverage. Please review.

Project coverage is 19.53%. Comparing base (f393b6b) to head (a9ec768).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/ui/classic.vue 0.00% 3 Missing ⚠️
...ackages/frontend/src/components/MkNoteDetailed.vue 0.00% 2 Missing ⚠️
packages/frontend/src/store.ts 0.00% 2 Missing ⚠️
packages/frontend/src/ui/universal.vue 0.00% 2 Missing ⚠️
packages/frontend/src/boot/common.ts 0.00% 1 Missing ⚠️
packages/frontend/src/boot/main-boot.ts 0.00% 1 Missing ⚠️
...ckages/frontend/src/components/MkCropperDialog.vue 0.00% 1 Missing ⚠️
packages/frontend/src/components/MkDonation.vue 0.00% 1 Missing ⚠️
...s/frontend/src/components/MkEmbedCodeGenDialog.vue 0.00% 1 Missing ⚠️
packages/frontend/src/components/MkPreview.vue 0.00% 1 Missing ⚠️
... and 46 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14536      +/-   ##
===========================================
- Coverage    19.57%   19.53%   -0.05%     
===========================================
  Files          717      713       -4     
  Lines       100466   100287     -179     
  Branches      1005      997       -8     
===========================================
- Hits         19669    19591      -78     
+ Misses       80251    80152      -99     
+ Partials       546      544       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines -511 to -512
// 再生速度の選択などのために、Audio要素のコンテキストメニューはブラウザデフォルトとする。
if (el.tagName === 'AUDIO') return true;
Copy link
Contributor Author

@kakkokari-gtyih kakkokari-gtyih Sep 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

音声UIは独自UIに変更された+右クリック伝播防止はMkMediaAudio側に入っているので完全に共通化してOK

@kakkokari-gtyih kakkokari-gtyih added this to the v2024.9.0 milestone Sep 10, 2024
@syuilo syuilo merged commit 837a8e1 into misskey-dev:develop Sep 10, 2024
21 checks passed
@syuilo
Copy link
Member

syuilo commented Sep 10, 2024

🙏🏿

@kakkokari-gtyih kakkokari-gtyih deleted the refactor-14530 branch September 10, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

frontend: frontend-embed/src/to-be-shared を共通化する
2 participants