-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(frontend): frontend-embed/src/to-be-sharedを共通化 #14536
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #14536 +/- ##
===========================================
- Coverage 19.57% 19.53% -0.05%
===========================================
Files 717 713 -4
Lines 100466 100287 -179
Branches 1005 997 -8
===========================================
- Hits 19669 19591 -78
+ Misses 80251 80152 -99
+ Partials 546 544 -2 ☔ View full report in Codecov by Sentry. |
// 再生速度の選択などのために、Audio要素のコンテキストメニューはブラウザデフォルトとする。 | ||
if (el.tagName === 'AUDIO') return true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
音声UIは独自UIに変更された+右クリック伝播防止はMkMediaAudio側に入っているので完全に共通化してOK
🙏🏿 |
What
書いてあるとおり
Why
Fix #14530
Additional info (optional)
Checklist