fix(backend): happy-domで外部HTMLをパースする際に関連リソースが読み込まれる問題を修正 #14521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
version 10 didn't quite support disabling all of that I have tested that `MfmService` (the other code that uses `happy-dom`) still works fine: the RSS feed for a user is generated correctly, with HTML rendered from MFM (cherry picked from commit 26e0412)
|
このPRによるapi.jsonの差分 差分はこちら |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #14521 +/- ##
============================================
+ Coverage 19.53% 39.62% +20.09%
============================================
Files 713 1535 +822
Lines 100287 190816 +90529
Branches 997 2597 +1600
============================================
+ Hits 19591 75618 +56027
- Misses 80152 114637 +34485
- Partials 544 561 +17 ☔ View full report in Codecov by Sentry. |
|
🙏🏿 |
|
Sharkeyでこの変更からしばらくしたあとにメモリ使用量の瞬間的な増加が見られたらしいのでやっぱあかんかもしれない（原因の切り分けまではまだ行われていないので今なにかをするというよりかはそういうことがあったということを覚えておく程度で良い） |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
version 10 didn't quite support disabling all of that
I have tested that
MfmService(the other code that useshappy-dom) still works fine: the RSS feed for a user is generated correctly, with HTML rendered from MFM(cherry picked from commit 26e0412fbb91447c37e8fb06ffb0487346063bb8)
What
https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/610?commit_id=f244d425005ae662cfb94f2a18e38cedadfb3c0a#note_5069
Why
無駄かも
Additional info (optional)
v14で見られたメモリリークはv15になるときのリファクタリングで解消されたかもしれないという報告があるけど真偽は不明
capricorn86/happy-dom#1055 (comment)
Checklist