Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(frontend): 非推奨の表現を改める #14517

Merged

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Sep 6, 2024

What

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 3.03030% with 32 lines in your changes missing coverage. Please review.

Project coverage is 19.57%. Comparing base (f393b6b) to head (b2f5168).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
...rontend/src/pages/settings/preferences-backups.vue 0.00% 30 Missing ⚠️
packages/frontend/src/scripts/code-highlighter.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #14517   +/-   ##
========================================
  Coverage    19.57%   19.57%           
========================================
  Files          717      717           
  Lines       100466   100465    -1     
  Branches      1005     1005           
========================================
  Hits         19669    19669           
+ Misses       80251    80250    -1     
  Partials       546      546           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih
Copy link
Contributor Author

👀

@kakkokari-gtyih kakkokari-gtyih added this to the v2024.9.0 milestone Sep 9, 2024
@kakkokari-gtyih
Copy link
Contributor Author

このPRで変えた部分だけi18n.t()を使い続けていた理由とかってあるのかしら

@acid-chicken
Copy link
Member

このPRで変えた部分だけi18n.t()を使い続けていた理由とかってあるのかしら

7881f06
5764848

@kakkokari-gtyih
Copy link
Contributor Author

kakkokari-gtyih commented Sep 10, 2024

このPRで変えた部分だけi18n.t()を使い続けていた理由とかってあるのかしら

7881f06 5764848

どちらも特に問題なさそうではある(MkPostFormAttaches.vueは時期的に過渡期だった可能性がある。preferences-backups.vueはi18nの書き方が特殊だったから置き換え漏れたとか?)

@acid-chicken
Copy link
Member

コミット日付

@syuilo syuilo merged commit 1544ba9 into misskey-dev:develop Sep 15, 2024
20 checks passed
@syuilo
Copy link
Member

syuilo commented Sep 15, 2024

🙏🏿

@kakkokari-gtyih kakkokari-gtyih deleted the refactor-replace-deprecated-methods branch September 15, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants