-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(backend/antenna): キーワードが与えられなかった場合のエラーをApiErrorとして投げる #14491
Merged
syuilo
merged 8 commits into
misskey-dev:develop
from
KisaragiEffective:make-apierror-on-empty-antenna-update
Sep 15, 2024
Merged
fix(backend/antenna): キーワードが与えられなかった場合のエラーをApiErrorとして投げる #14491
syuilo
merged 8 commits into
misskey-dev:develop
from
KisaragiEffective:make-apierror-on-empty-antenna-update
Sep 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
このPRによるapi.jsonの差分 差分はこちら--- base
+++ head
@@ -17260,6 +17260,15 @@
}
}
},
+ "EMPTY_KEYWORD": {
+ "value": {
+ "error": {
+ "message": "Either keywords or excludeKeywords is required.",
+ "code": "EMPTY_KEYWORD",
+ "id": "53ee222e-1ddd-4f9a-92e5-9fb82ddb463a"
+ }
+ }
+ },
"INVALID_PARAM": {
"value": {
"error": {
@@ -18145,6 +18154,15 @@
}
}
},
+ "EMPTY_KEYWORD": {
+ "value": {
+ "error": {
+ "message": "Either keywords or excludeKeywords is required.",
+ "code": "EMPTY_KEYWORD",
+ "id": "721aaff6-4e1b-4d88-8de6-877fae9f68c4"
+ }
+ }
+ },
"INVALID_PARAM": {
"value": {
"error": { |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #14491 +/- ##
============================================
+ Coverage 19.53% 39.52% +19.99%
============================================
Files 713 1535 +822
Lines 100293 190834 +90541
Branches 997 3498 +2501
============================================
+ Hits 19591 75433 +55842
- Misses 80158 114807 +34649
- Partials 544 594 +50 ☔ View full report in Codecov by Sentry. |
/preview |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
done in 24eb394 |
(疲労困憊なので明日になったら内容確認します) |
元のissueは緊急度が低い案件なのでご都合の良いときで良いです |
🙏🏿 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
題名通り
Why
close #14492
Additional info (optional)
n/a
Checklist