Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(backend): use Reflect for bindThis decorator #14482

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

zzau13
Copy link
Contributor

@zzau13 zzau13 commented Aug 31, 2024

Using Reflect.defineProperty instead of Object.defineProperty gives a more consistent behavior with the rest of the modern JavaScript features.

What

Update to modern Javascript features

Why

Improve the code

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Using Reflect.defineProperty instead of Object.defineProperty
gives a more consistent behavior with the rest of the modern
JavaScript features.
@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Aug 31, 2024
Copy link
Contributor

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

Copy link

codecov bot commented Aug 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.82%. Comparing base (a3d236c) to head (818b156).
Report is 80 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14482      +/-   ##
===========================================
- Coverage    41.74%   39.82%   -1.93%     
===========================================
  Files         1549     1547       -2     
  Lines       196555   190953    -5602     
  Branches      2767     3422     +655     
===========================================
- Hits         82055    76040    -6015     
- Misses      113939   114327     +388     
- Partials       561      586      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit 07f26bc into misskey-dev:develop Sep 15, 2024
27 checks passed
@syuilo
Copy link
Member

syuilo commented Sep 15, 2024

🙏🏿

@zzau13 zzau13 deleted the decorators branch September 15, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants