Fix: Continue importing from file if single emoji import fails #14461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
このPRによるapi.jsonの差分 差分はこちら |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #14461 +/- ##
===========================================
- Coverage 39.63% 39.56% -0.08%
===========================================
Files 1542 1542
Lines 192690 192697 +7
Branches 3562 3533 -29
===========================================
- Hits 76376 76234 -142
- Misses 115717 115866 +149
Partials 597 597 ☔ View full report in Codecov by Sentry. |
packages/backend/src/queue/processors/ImportCustomEmojisProcessorService.ts
Outdated
Show resolved
Hide resolved
packages/backend/src/queue/processors/ImportCustomEmojisProcessorService.ts
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
|
i have done so |
KisaragiEffective
approved these changes
Aug 28, 2024
|
conflict resolved |
|
🙏🏻 |
HotoRas
pushed a commit
to HotoRas/misskey-neko
that referenced
this pull request
Sep 27, 2024
…ey-dev#14461) * Fix: Continue importing from file if single emoji import fails * Fix indentation --------- Co-authored-by: かっこかり <[email protected]> Co-authored-by: syuilo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add a try/catch block to the DriveService.addFile call to allow other emojis to be processed in the case of a missing one.
Why
There are potentially still good emojis in a file after one bad one, so interrupting the import process is bad behavior.
Additional info (optional)
Checklist
Fixes #14460