Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playの編集画面の保存ボタン等をstickyにする など #14429

Merged
merged 8 commits into from
Sep 24, 2024

Conversation

FineArchs
Copy link
Contributor

@FineArchs FineArchs commented Aug 17, 2024

What

Playの編集画面の、

misskey-flash-sticky2.mp4

Why

  • 画面をスクロールしなくても保存・表示が行われるようにする
  • 公開範囲は重要な設定項目であるため上部に置く

Additional info (optional)

表示/削除ボタンの背景が強く透過されているが、デザイン的に良いのか悪いのかはわからない 修正済み

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Aug 17, 2024
Copy link

codecov bot commented Aug 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 19.72%. Comparing base (daf9ae5) to head (228ad91).
Report is 60 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/pages/flash/flash-edit.vue 0.00% 24 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14429      +/-   ##
===========================================
+ Coverage    19.53%   19.72%   +0.18%     
===========================================
  Files          713      713              
  Lines       100375   100388      +13     
  Branches       997      995       -2     
===========================================
+ Hits         19612    19802     +190     
+ Misses       80219    80044     -175     
+ Partials       544      542       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

packages/frontend/src/pages/flash/flash-edit.vue Outdated Show resolved Hide resolved
@kakkokari-gtyih kakkokari-gtyih dismissed their stale review August 18, 2024 11:29

Correctly modified

@kakkokari-gtyih kakkokari-gtyih added this to the v2024.8.1 (?) milestone Aug 20, 2024
@kakkokari-gtyih
Copy link
Contributor

コンフリクト解消

@kakkokari-gtyih
Copy link
Contributor

コンフリクト解消

@syuilo syuilo merged commit aef1506 into misskey-dev:develop Sep 24, 2024
20 checks passed
@syuilo
Copy link
Member

syuilo commented Sep 24, 2024

👍🏻

@FineArchs FineArchs deleted the flash-sticky branch September 26, 2024 03:41
HotoRas pushed a commit to HotoRas/misskey-neko that referenced this pull request Sep 27, 2024
* flash: sticky buttons

* sticky save buttons

* fix

* add spacer

* fix design

* Update CHANGELOG.md

* revert experimental background

* add background

* Update CHANGELOG.md

---------

Co-authored-by: かっこかり <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants