-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: running from docker is broken #12824
Merged
syuilo
merged 4 commits into
misskey-dev:develop
from
anatawa12:fix-docker-build-failure
Dec 27, 2023
Merged
fix: running from docker is broken #12824
syuilo
merged 4 commits into
misskey-dev:develop
from
anatawa12:fix-docker-build-failure
Dec 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
今修正の動作確認中 @ local |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12824 +/- ##
===========================================
- Coverage 79.95% 79.94% -0.01%
===========================================
Files 956 955 -1
Lines 108864 108800 -64
Branches 8413 8413
===========================================
- Hits 87045 86984 -61
+ Misses 21819 21816 -3 ☔ View full report in Codecov by Sentry. |
治ってなかった
|
anatawa12
force-pushed
the
fix-docker-build-failure
branch
from
December 27, 2023 14:48
04be987
to
01ea2df
Compare
anatawa12
force-pushed
the
fix-docker-build-failure
branch
from
December 27, 2023 14:52
01ea2df
to
7f46658
Compare
まで動作確認しました |
@misskey-dev/dev |
CHANGELOG忘れてた今から書きます |
DONE |
Merged
Co-authored-by: かっこかり <[email protected]>
🙏 |
camilla-ett
pushed a commit
to kaseiski/misskey
that referenced
this pull request
Jan 2, 2024
* fix: running from docker is broken * fix: dependencies of misskey-js not found from backend * docs(changelog): Dockerでサーバーを起動できない問題を修正 * Update CHANGELOG.md Co-authored-by: かっこかり <[email protected]> --------- Co-authored-by: かっこかり <[email protected]>
madonuko
pushed a commit
to FyraLabs/nyaakey
that referenced
this pull request
Feb 26, 2024
* fix: running from docker is broken * fix: dependencies of misskey-js not found from backend * docs(changelog): Dockerでサーバーを起動できない問題を修正 * Update CHANGELOG.md Co-authored-by: かっこかり <[email protected]> --------- Co-authored-by: かっこかり <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #12822
misskey-jsのビルド済バイナリ(js)がpackages/misskey-js/builtになかったせいで落ちてたのでコピーするようにした
Why
Additional info (optional)
Checklist