Use generate-api-json for api.json diff GitHub comment #12408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12408 +/- ##
========================================
Coverage 78.63% 78.63%
========================================
Files 176 176
Lines 23334 23334
Branches 495 495
========================================
Hits 18349 18349
Misses 4985 4985 ☔ View full report in Codecov by Sentry. |
anatawa12
force-pushed
the
use-generate-api-json-for-github-comment
branch
from
3cb1d47 to
c4a16bf
Compare
|
フロントのビルド遅いから除こうと思ったけどだめですね。フルビルドに戻しました。 |
|
このPRによるapi.jsonの差分 差分はこちら |
|
ゆくゆくやろうと思ってはいたんですが動作する条件をpackages/backend以下が変更されたらに絞ってもいいかも |
|
たしかにそうですね。 |
|
本当はdiffがない場合のメッセージも変えようと思っているんですがさすがに自分でやる |
tai-cha
approved these changes
Nov 22, 2023
|
🙏🙏🙏 |
Merged
camilla-ett
pushed a commit
to kaseiski/misskey
that referenced
this pull request
Jan 2, 2024
…2408) * ci: use generate-api-json to get api.json changes * restore copying default.yml * refactor: get api.json with single workflow * ci: api.jsonのdiffをbackendが変更されたときのみ取るように
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
githubのprへのコメントで使用するapi.jsonを #12402 で追加された
generate-api-jsonで生成するようにしました。Why
Additional info (optional)
get-api-diff.ymlはpull_requestイベントで発火するため、pull requestのheadのget-api-diff.ymlが使われるはずなため、generate-api-jsonコマンドがなくてエラーになることはないはずです。Checklist