Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend) api/iの未読のお知らせにcreatedAtを追加するように修正 #12092

Merged

Conversation

shiosyakeyakini-info
Copy link
Contributor

@shiosyakeyakini-info shiosyakeyakini-info commented Oct 20, 2023

What

api/iunreadAnnouncementscreatedAtを再生成する処理を追加しました

Why

エンティティの定義と合わせるため Related: #12091

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Oct 20, 2023
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (42a3489) 79.38% compared to head (cc16e2c) 79.26%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12092      +/-   ##
===========================================
- Coverage    79.38%   79.26%   -0.12%     
===========================================
  Files          932      932              
  Lines        99724    99728       +4     
  Branches      8135     8108      -27     
===========================================
- Hits         79161    79051     -110     
- Misses       20563    20677     +114     
Files Coverage Δ
...ges/backend/src/core/entities/UserEntityService.ts 98.80% <60.00%> (-0.40%) ⬇️

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo
Copy link
Member

syuilo commented Oct 20, 2023

🙏🏻🙏🏻

kanarikanaru pushed a commit to kanarikanaru/misskey that referenced this pull request Nov 2, 2023
kanarikanaru pushed a commit to kanarikanaru/misskey that referenced this pull request Nov 9, 2023
@shiosyakeyakini-info shiosyakeyakini-info deleted the fix_unreadannouncements branch November 17, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants