chore: Pull Request時にapi.jsonの差分を表示するActions workflow #12090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tai-cha
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12090 +/- ##
===========================================
- Coverage 79.38% 79.22% -0.16%
===========================================
Files 932 930 -2
Lines 99724 99554 -170
Branches 8135 8106 -29
===========================================
- Hits 79161 78876 -285
- Misses 20563 20678 +115 ☔ View full report in Codecov by Sentry. |
tai-cha
force-pushed
the
feat/api-diff
branch
from
c269986 to
dd72c8a
Compare
|
おそらくコード上は問題ないけどmisskeyのリポジトリ上でGitHub ActionsがPRにコメントを書き込む権限がない |
|
リポジトリの読み取り、PullRequestの読み取りとコメントを書き込む権限が必要なので少し細かめにセットするべきか |
|
一応動作イメージはこう |
|
👍🏻👍🏻👍🏻👍🏻 |
kanarikanaru
pushed a commit
to kanarikanaru/misskey
that referenced
this pull request
Nov 2, 2023
) * chore: Pull Request時にapi.jsonのdiffを出力するworkflow * refactor: job names * fix: set repository to get api diff * chore: set permission to workflow * set sleep 30s (shorter) * chore: set label of diff * chore: more attempts to fetch misskey * chore: add full diff output of api.js * chore: save full-diff to Artifact * chore: add message to download diff Artifact
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
GitHub Actionsを利用してコメントにheadとbase間のapi.jsonのdiffを出力するようにした
ついでに副産物としてapi.jsonのスナップショットとfull diffが90日間GitHubからDLできるようになる
Why
resolve: masterマージ時のPRでapi.jsonのdiffを出力できないか #11928
Additional info (optional)
Checklist