-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: 未読通知数を表示できるように #11982
Feat: 未読通知数を表示できるように #11982
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #11982 +/- ##
===========================================
- Coverage 79.18% 79.01% -0.17%
===========================================
Files 944 177 -767
Lines 101181 23093 -78088
Branches 8222 493 -7729
===========================================
- Hits 80117 18248 -61869
+ Misses 21064 4845 -16219 ☔ View full report in Codecov by Sentry. |
…ih/misskey into unread-notif-count
オプトインにする必要あんまり感じないかも(常にオンで良さそう) |
文字自体の大きさはそれで良さそうで、paddingをもうちょっと追加すればいい感じになりそう |
同じような(もしくは全く同じ?)スタイルが5か所くらいに追加されてるからコンポーネントにするかstyle.scssにクラスとしてまとめるのがよさそう |
このPRによるapi.jsonの差分 差分はこちら--- base
+++ head
@@ -58159,6 +58159,11 @@
"nullable": false,
"optional": false
},
+ "unreadNotificationsCount": {
+ "type": "number",
+ "nullable": false,
+ "optional": false
+ },
"mutedWords": {
"type": "array",
"nullable": false,
@@ -58241,6 +58246,7 @@
"hasUnreadAntenna",
"hasUnreadNotification",
"hasPendingReceivedFollowRequest",
+ "unreadNotificationsCount",
"mutedWords",
"mutedInstances",
"notificationRecieveConfig", |
デフォルトONでオフにできるようにしておきます |
navbar-for-mobileとかで _indicateCounter を使っていないのは理由ある? |
_indicateCounter にしても問題なさそうだったから _indicateCounter にした |
👍🏻 |
* 未読通知数を表示できるように * Update Changelog * オプトインにする * Fix lint * (add) テスト通知のプッシュ通知を追加 * add test * フロントエンドの表示上限を99に変更 * Make it default on * 共通スタイルをくくりだす * Update Changelog * tweak * Update UserEntityService.ts * rename * Update navbar-for-mobile.vue --------- Co-authored-by: syuilo <[email protected]> # Conflicts: # CHANGELOG.md # packages/misskey-js/etc/misskey-js.api.md
What
/api/i
にunreadNotificationCount
を追加Why
Fix #11981
Additional info (optional)
デザインは改良の余地あり(文字が小さすぎる)
Checklist