絵文字重複チェック #11941
Merged
絵文字重複チェック #11941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #11941 +/- ##
===========================================
+ Coverage 79.00% 79.34% +0.33%
===========================================
Files 928 928
Lines 99089 99306 +217
Branches 7913 8065 +152
===========================================
+ Hits 78289 78794 +505
+ Misses 20800 20512 -288
☔ View full report in Codecov by Sentry. |
syuilo
reviewed
Oct 4, 2023
syuilo
reviewed
Oct 4, 2023
syuilo
reviewed
Oct 4, 2023
packages/backend/src/server/api/endpoints/admin/emoji/update.ts
Outdated
Show resolved
Hide resolved
|
🙏🙏🙏 |
Co-authored-by: syuilo <[email protected]>
Co-authored-by: syuilo <[email protected]>
Co-authored-by: syuilo <[email protected]>
|
🙏🏻 |
kanarikanaru
pushed a commit
to kanarikanaru/misskey
that referenced
this pull request
Oct 12, 2023
* 絵文字重複チェック * アップデート時のチェック * Update packages/backend/src/core/CustomEmojiService.ts Co-authored-by: syuilo <[email protected]> * Update packages/backend/src/server/api/endpoints/admin/emoji/add.ts Co-authored-by: syuilo <[email protected]> * Update packages/backend/src/server/api/endpoints/admin/emoji/update.ts Co-authored-by: syuilo <[email protected]> --------- Co-authored-by: syuilo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
絵文字の追加・アップデートにて名前の重複をチェックするように(#11834)
Why
重複チェックが無いため、同じ絵文字を追加してしまう場合が発生する
インポート時は未チェックの為TODOかも
Additional info (optional)
ローカルにてテスト済み
Checklist