Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: register_post_form_actionでcwを変更可能にする #11911

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

tai-cha
Copy link
Contributor

@tai-cha tai-cha commented Sep 28, 2023

What

register_post_form_actionでcwを変更可能にする
resolve #11910

Why

CWをなんとかしたい的な需要はあるがMisskey本体のカスタムでは難しいものもあるためプラグインで変更可能にすることで利便性を高める

Additional info (optional)

動作確認用に書いたプラグイン

/// @ 0.13.3
### {
  name: "test"
  version: "0.1.1"
  author: "taichan"
  description: "CWをワンボタンで呼び出します"
  permissions: []
  config: {
    cwList: {
      type: 'string'
      label: "セットするCWのリスト"
      description: "記憶するCWの文章を入力(複数の場合はカンマ区切りで)"
      default: ""
    }
  }
}

each let cw, Plugin:config.cwList.split(",") {
  Plugin:register_post_form_action(`CWをセット: {cw.slice(0, 5)}`, @(f, update){ update("cw", cw) })
}

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Sep 28, 2023
@tai-cha tai-cha changed the title Feat/post form action cw Feat: register_post_form_actionでcwを変更可能にする Sep 28, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (ce1218a) 78.77% compared to head (6c941bf) 78.80%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11911      +/-   ##
===========================================
+ Coverage    78.77%   78.80%   +0.02%     
===========================================
  Files          928      929       +1     
  Lines        98692    98799     +107     
  Branches      7849     7854       +5     
===========================================
+ Hits         77743    77856     +113     
+ Misses       20949    20943       -6     
Files Coverage Δ
packages/frontend/src/components/MkPostForm.vue 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit 63c6a9b into misskey-dev:develop Sep 28, 2023
15 checks passed
@syuilo
Copy link
Member

syuilo commented Sep 28, 2023

👍🏻

@tai-cha tai-cha deleted the feat/post_form_action_cw branch September 28, 2023 07:21
Kesefon pushed a commit to Kesefon/misskey that referenced this pull request Mar 6, 2024
* 投稿フォームのアクション追加するプラグインでCWを変更可能にする

* Update CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: [plugin] register_post_form_actionでcwを変更可能にする
2 participants