-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: テスト通知を送信できるようにする #11810
Merged
Merged
feat: テスト通知を送信できるようにする #11810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #11810 +/- ##
========================================
Coverage 78.69% 78.69%
========================================
Files 174 174
Lines 22796 22796
Branches 511 511
========================================
Hits 17940 17940
Misses 4856 4856 ☔ View full report in Codecov by Sentry. |
github-actions
bot
added
packages/backend
Server side specific issue/PR
packages/misskey-js
labels
Sep 10, 2023
kakkokari-gtyih
changed the title
feat(frontend): テスト通知を送信できるようにする
feat: テスト通知を送信できるようにする
Sep 10, 2023
通知の表示され方のテストはクライアントだけで完結させたいと言おうとしてたらそうしてくださったのですわね misskey-jsでpnpm apiを実行する必要がありそう |
やりましたー |
👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
packages/backend
Server side specific issue/PR
packages/frontend
Client side specific issue/PR
packages/misskey-js
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #10768
What
バックエンド
test
が追加されました(通知無効設定を通過するために独自タイプを作成)notifications/test-notification
が追加されましたフロントエンド
テスト通知の表示はこんな感じ
Why
フロントエンド・バックエンドで通知のテストを別で設けた理由
サーバーサイドへの負荷軽減と、通知欄がテスト通知で埋まらないようにするため
Additional info (optional)
Checklist