Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: passkey support #11804

Merged
merged 7 commits into from
Sep 8, 2023
Merged

feat: passkey support #11804

merged 7 commits into from
Sep 8, 2023

Conversation

syuilo
Copy link
Member

@syuilo syuilo commented Sep 8, 2023

What

Resolve #11054

大部分は MisskeyIO#149 から

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR packages/backend:test labels Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.12% ⚠️

Comparison is base (bc52d7a) 78.81% compared to head (24dfded) 78.70%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11804      +/-   ##
===========================================
- Coverage    78.81%   78.70%   -0.12%     
===========================================
  Files          926      174     -752     
  Lines        97862    22771   -75091     
  Branches      7778      511    -7267     
===========================================
- Hits         77132    17921   -59211     
+ Misses       20730     4850   -15880     

see 749 files with indirect coverage changes

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@syuilo syuilo marked this pull request as ready for review September 8, 2023 03:22
@syuilo
Copy link
Member Author

syuilo commented Sep 8, 2023

マージするか

@syuilo
Copy link
Member Author

syuilo commented Sep 8, 2023

Chromeはパスキー対応してないらしく動作確認できないけどマージ

@syuilo syuilo merged commit ff9a65e into develop Sep 8, 2023
@syuilo syuilo deleted the passkey branch September 8, 2023 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend:test packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

パスキーのサポート
1 participant