Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat graceful shutdown 終了時に穏便に死ぬようにする #11734

Closed

Conversation

fruitriin
Copy link
Contributor

@fruitriin fruitriin commented Aug 17, 2023

What

#10995
Misskeyのバックエンドプロセスがちゃんと死ぬようにする

Why

Additional info (optional)

https://github.com/hemerajs/fastify-graceful-shutdown
こいつを入れる

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Aug 17, 2023
@github-actions github-actions bot requested review from EbiseLutica and syuilo August 17, 2023 14:48
@fruitriin fruitriin changed the title Feat graceful shutdown Feat graceful shutdown 終了時に穏便に死ぬようにする Aug 17, 2023
@fruitriin fruitriin force-pushed the feat_graceful-shutdown branch from 8b809c4 to a306f37 Compare August 17, 2023 14:56
@syuilo
Copy link
Member

syuilo commented Aug 19, 2023

ありがとうございます 🙏🏻

  • チェックリストにある項目をご確認ください
  • クォートを他の個所と統一してください
  • 不必要なdiffが含まれています

@@ -216,6 +216,7 @@
"eslint": "8.46.0",
"eslint-plugin-import": "2.28.0",
"execa": "7.2.0",
"fastify-graceful-shutdown": "^3.5.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

devDependencies になっています

@@ -31,7 +31,7 @@ import { FileServerService } from './FileServerService.js';
import { ClientServerService } from './web/ClientServerService.js';
import { OpenApiServerService } from './api/openapi/OpenApiServerService.js';
import { OAuth2ProviderService } from './oauth/OAuth2ProviderService.js';

import fasitfyGracefulShutdown from "fastify-graceful-shutdown"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

細かいですが、誤字の修正をお願いします~!
fasitfyfastify

@syuilo
Copy link
Member

syuilo commented Sep 18, 2023

Error: SIGINT handler was already registered use fastify.gracefulShutdownが出る

@fruitriin fruitriin closed this Oct 9, 2023
@fruitriin fruitriin deleted the feat_graceful-shutdown branch September 22, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants