Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(frontend): renote of note in sensitive channel is now home renote by default. #11476

Merged

Conversation

anatawa12
Copy link
Member

What

Closes #11270

Why

issue参照

backend側で強制にしていない理由は Sensitive Channel の note だからといってGTLに投げてはいけないnoteだけとは限らないと思うため、by defaultにしています

Additional info (optional)

Changelogの場所をGeneralのSensitive指定にくっつけるかClientにするか悩んでClientにしましたがどっちの方がいいですかね

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Aug 6, 2023
@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Merging #11476 (38d17e5) into develop (1d55708) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #11476      +/-   ##
===========================================
- Coverage    78.72%   78.60%   -0.13%     
===========================================
  Files          920      920              
  Lines        97388    97394       +6     
  Branches      7723     7690      -33     
===========================================
- Hits         76671    76558     -113     
- Misses       20717    20836     +119     
Files Changed Coverage Δ
packages/frontend/src/components/MkNote.vue 100.00% <100.00%> (ø)

... and 19 files with indirect coverage changes

@syuilo syuilo merged commit 4c3935b into misskey-dev:develop Sep 7, 2023
8 checks passed
@syuilo
Copy link
Member

syuilo commented Sep 7, 2023

👍🏻

@anatawa12 anatawa12 deleted the renote-sensitive-home-by-default branch September 7, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

チャンネルをNSFW(センシティブ)に設定出来るようにして欲しい
2 participants