Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ローカルのみノート検索 #11451

Merged
merged 7 commits into from
Aug 20, 2023

Conversation

tai-cha
Copy link
Contributor

@tai-cha tai-cha commented Aug 3, 2023

What

ノート検索へのローカルのみオプションの追加

Why

ローカルに範囲を絞ってノート検索したい場合がある
resolve #10310

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR labels Aug 3, 2023
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #11451 (76d71da) into develop (750085f) will decrease coverage by 0.06%.
The diff coverage is 15.38%.

❗ Current head 76d71da differs from pull request most recent head 1dc316e. Consider uploading reports for the commit 1dc316e to get more accurate results

@@             Coverage Diff             @@
##           develop   #11451      +/-   ##
===========================================
- Coverage    78.78%   78.72%   -0.06%     
===========================================
  Files          174      921     +747     
  Lines        22743    97916   +75173     
  Branches       520     7837    +7317     
===========================================
+ Hits         17917    77085   +59168     
- Misses        4826    20831   +16005     
Files Changed Coverage Δ
packages/backend/src/core/SearchService.ts 33.18% <15.38%> (ø)

... and 758 files with indirect coverage changes

@syuilo syuilo merged commit af80635 into misskey-dev:develop Aug 20, 2023
@syuilo
Copy link
Member

syuilo commented Aug 20, 2023

👍🏻

kanarikanaru pushed a commit to kanarikanaru/misskey that referenced this pull request Aug 20, 2023
* Add local search

* Update CHANGELOG

* lint

* Remove TODO comment

* lint

* Update packages/backend/src/core/SearchService.ts

---------

Co-authored-by: syuilo <[email protected]>
kanarikanaru added a commit to kanarikanaru/misskey that referenced this pull request Aug 20, 2023
taichan(taichanNE30)さんによる、ノートをローカルに限定して検索できる機能を先行実装。
misskey-dev#11451
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

検索時の検索範囲選択
2 participants