Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

プロフィールにその人が作ったPlayの一覧出せるように #11445

Merged
merged 13 commits into from
Aug 21, 2023

Conversation

GrapeApple0
Copy link
Contributor

What

プロフィールのタブにPlayタブを追加して、その人が作成したPlay一覧を表示できるようにしました。
screenshot 803

Why

その人が作ったPlay一覧をページの表示できなかったので作成しました。

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR packages/misskey-js labels Aug 1, 2023
@github-actions github-actions bot requested review from acid-chicken and syuilo August 1, 2023 13:19
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #11445 (0bdab31) into develop (f664f94) will increase coverage by 0.12%.
Report is 2 commits behind head on develop.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #11445      +/-   ##
===========================================
+ Coverage    78.64%   78.77%   +0.12%     
===========================================
  Files          922      174     -748     
  Lines        97391    22745   -74646     
  Branches      7743      520    -7223     
===========================================
- Hits         76596    17918   -58678     
+ Misses       20795     4827   -15968     

see 749 files with indirect coverage changes

@FineArchs
Copy link
Contributor

できればplayの非表示設定が出来るようになると大変助かります。
制作途中のplayは見せたくないとか、公開用と開発用を分けているとか色々あるので…

@syuilo
Copy link
Member

syuilo commented Aug 20, 2023

packages/backend/src/server/api/endpoints/flash/show.ts が変更されているのは何故でしょう?

@GrapeApple0
Copy link
Contributor Author

私の編集間違いです
不要な変更なので削除してきます

* private ... プロフィールには表示しない
*/
@Column('enum', { enum: ['public', 'private'] })
public visibility: 'public' | 'private';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こっちも更新する必要がありますね

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正しました。

Suggested change
public visibility: 'public' | 'private';
@Column('varchar', {
default: 'public',
})
public visibility: 'public' | 'private';

@syuilo syuilo merged commit 70a7800 into misskey-dev:develop Aug 21, 2023
@syuilo
Copy link
Member

syuilo commented Aug 21, 2023

👍🏻

@GrapeApple0
Copy link
Contributor Author

ありがとうございます

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR packages/misskey-js
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants