Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix offscreencanvas undefined #11017

Merged
merged 5 commits into from
Jun 26, 2023

Conversation

yuriha-chan
Copy link
Contributor

What

Fixes #11016
burahaで描画時にブラウザがOffscreenCanvasに対応していない場合に、エラーをcatchして未対応と報告する

Why

Additional info (optional)

iOSやMac端末を持っていないので、Chromeからの閲覧でエラーが生じないことのみチェックしています。

Checklist

  • [ x ] Read the contribution guide
  • [ x ] Test working in a local environment (partially)
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jun 15, 2023
@github-actions github-actions bot requested review from acid-chicken and tamaina June 15, 2023 14:38
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #11017 (9e43ef4) into develop (f5dfb64) will decrease coverage by 0.19%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #11017      +/-   ##
===========================================
- Coverage    77.47%   77.29%   -0.19%     
===========================================
  Files          909      907       -2     
  Lines        91516    91361     -155     
  Branches      6890     7512     +622     
===========================================
- Hits         70904    70619     -285     
- Misses       20612    20742     +130     
Impacted Files Coverage Δ
packages/frontend/src/workers/test-webgl2.ts 85.71% <100.00%> (-14.29%) ⬇️

... and 23 files with indirect coverage changes

@syuilo syuilo merged commit 58a898d into misskey-dev:develop Jun 26, 2023
@syuilo
Copy link
Member

syuilo commented Jun 26, 2023

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOSを最新版にしないと読み込み時エラーになってしまう(らしい)
4 participants