Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] 2FAリカバリコードの実装 #10972

Closed

Conversation

daima3629
Copy link
Contributor

What

Resolve #3566

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR labels Jun 7, 2023
@daima3629 daima3629 changed the title [Add] 2FAリカバリーコード仮実装 [Feature] 2FAリカバリコードの実装 Jun 7, 2023
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #10972 (0c58cc1) into develop (6182a1c) will decrease coverage by 0.01%.
The diff coverage is 69.13%.

@@             Coverage Diff             @@
##           develop   #10972      +/-   ##
===========================================
- Coverage    77.43%   77.42%   -0.01%     
===========================================
  Files          910      911       +1     
  Lines        91649    91730      +81     
  Branches      6882     6887       +5     
===========================================
+ Hits         70968    71026      +58     
- Misses       20681    20704      +23     
Impacted Files Coverage Δ
...ver/api/endpoints/i/2fa/generate-recovery-codes.ts 64.28% <64.28%> (ø)
...ackages/backend/src/models/entities/UserProfile.ts 100.00% <100.00%> (ø)
packages/backend/src/server/api/EndpointsModule.ts 100.00% <100.00%> (ø)
packages/backend/src/server/api/endpoints.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@daima3629
Copy link
Contributor Author

image
image
とりあえず生成するときはこんな感じに表示

@kakkokari-gtyih
Copy link
Contributor

257c4fc で実装されたかもしれません

@daima3629
Copy link
Contributor Author

完全に放置しておりました…申し訳ありません
実装されたとのことなので、こちらはCloseします

@daima3629 daima3629 closed this Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2段階認証のバックアップコード
2 participants